fix: use current working directory as default for session metadata#2793
fix: use current working directory as default for session metadata#2793s-soroosh wants to merge 1 commit intoblock:mainfrom
Conversation
s-soroosh
force-pushed
the
fix-working-directory-when-session-has-no-messages
branch
from
1009ed7 to
67e1556
Compare
michaelneale
left a comment
michaelneale
left a comment
There was a problem hiding this comment.
see comment by @DOsinga - looks interesting but I think has to be a default does't there? otherwise it will just fail
s-soroosh
force-pushed
the
fix-working-directory-when-session-has-no-messages
branch
from
67e1556 to
6a4dc5f
Compare
|
@DOsinga @michaelneale Thanks for the reviews! Updated the code to fallback to home dir in case working directory cannot be determined |
|
I think CWD make more sense @s-soroosh I like this, but not entirely clear how to test/reproduce, code reads fine, but do you have a scenario to test with? |
|
@s-soroosh also will need DCO https://github.com/block/goose/pull/2793/checks?check_run_id=45675312414 it looks like but LGTM otherwise. |
|
ie if you could show some samples of it working new way - then I think we are good to go with this for next release |
|
actually DCO skipped, this needs to be udpated to main and should pass the build |
|
@s-soroosh mind updating this to main branch again? |
|
closing for now until more feedback |
|
Just curious what feedback is required for this patch? The issue is definitely a little painpoint in the CLI at the moment. |
|
Hey, I was busy this week and haven't found time yet to address the latest feedback. |
|
Reopened a PR with the same changes here. |
4 participants
Previously, when a session had no messages or an invalid working directory, it would default to the home directory. This changes the behavior to use the current working directory instead, which I think is more intuitive and matches user expectations.
Questions